From b75fe9bb99993b1cccd3ed167857f9eaf46efa4a Mon Sep 17 00:00:00 2001 From: Jan Date: Sat, 13 Dec 2025 17:24:14 +0100 Subject: [PATCH] Refine logging for `TaxationResolverService` to improve duty relevance and extraction insights. --- .../lcc/service/api/TaxationResolverService.java | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/main/java/de/avatic/lcc/service/api/TaxationResolverService.java b/src/main/java/de/avatic/lcc/service/api/TaxationResolverService.java index bdcccdb..f780ffb 100644 --- a/src/main/java/de/avatic/lcc/service/api/TaxationResolverService.java +++ b/src/main/java/de/avatic/lcc/service/api/TaxationResolverService.java @@ -292,18 +292,17 @@ public class TaxationResolverService { var measureType = MeasureType.fromMeasureCode(measure.getMeasureType().getMeasureType()); boolean maybeRelevant = measureType.map(MeasureType::containsRelevantDuty).orElse(false); - logger.info("Measure ({}{}, {}): is_relevant: {}", measureType.map(MeasureType::getSeries).orElse("UNKNOWN"), measureType.map(MeasureType::getMeasureCode).orElse(""), measureType.map(MeasureType::name).orElse("UNKNOWN"), maybeRelevant); if (maybeRelevant) { var duty = extractDuty(measure); if (duty.isPresent()) { - logger.info("Measure ({}{}, {}): duty: {}, hs code: {}", + logger.info("Measure ({}{}, {}): is_relevant: true, duty: {}, hs code: {}", measureType.map(MeasureType::getSeries).orElse("UNKNOWN"), measureType.map(MeasureType::getMeasureCode).orElse(""), measureType.map(MeasureType::name).orElse("UNKNOWN"), - measureType.map(MeasureType::getMeasureCode).orElse(null), + duty, entry.getKey().getReturn().getResult().getRequest().getGoodsCode()); @@ -316,8 +315,16 @@ public class TaxationResolverService { selectedMeasure = measureType.map(MeasureType::getMeasureCode).orElse(null); selectedHsCode = entry.getKey().getReturn().getResult().getRequest().getGoodsCode(); } + } else { + logger.info("Measure ({}{}, {}): is_relevant: true, no duty extracted", + measureType.map(MeasureType::getSeries).orElse("UNKNOWN"), + measureType.map(MeasureType::getMeasureCode).orElse(""), + measureType.map(MeasureType::name).orElse("UNKNOWN")); } + } else { + logger.info("Measure ({}{}, {}): is_relevant: false", measureType.map(MeasureType::getSeries).orElse("UNKNOWN"), measureType.map(MeasureType::getMeasureCode).orElse(""), measureType.map(MeasureType::name).orElse("UNKNOWN")); } + } }